This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Various i18n fixes/optimizations #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbiron
reviewed
May 5, 2020
There was a problem hiding this comment.
I think it will be easier if these changes are made in #103 instead.
Because if this is merged, then master won't be able to merged into that PR branch without resolving conflicts because that PR changes all (or at least most) of the same lines for other reasons.
|
Ok, so let's say that we wait for #103 to be merged and then I refreshes this PR 🙂 |
|
Right, would be easier to merge 103 then refresh and merge these changes. As far as I see all the changes here look good. |
|
@pbiron I updated the PR accordingly, could you please take a look? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
aria-labelatttributesFixes Translation: Combine strings even if context is different #106 and partially Fix/enhance the UI around the link to enable/disable auto-updates #94 (see this comment)
automatic updateswithauto-updatesfor better consistencyFixes Translation: Consistency in wording #108
I kept some of the
automatic updatesstrings, when they appear in error messages.