Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Copy the plugin's site options to core's site options on self-deactivation #133

Merged
merged 2 commits into from
May 17, 2020

Conversation

pbiron
Copy link
Contributor

@pbiron pbiron commented May 17, 2020

This is a follow-up to #123.

@pbiron pbiron added the enhancement New feature or request label May 17, 2020
@pbiron pbiron added this to the 0.8.1 milestone May 17, 2020
@pbiron pbiron self-assigned this May 17, 2020
@pbiron pbiron requested review from azaozz and audrasjb May 17, 2020 17:46
@azaozz
Copy link
Contributor

azaozz commented May 17, 2020

This is a "courtesy fix" for the people that test(ed) the plugin, kind of "nice to do" :)

Can probably check if the old options are not empty before merging them with the new. Other than that looks good.

@pbiron pbiron merged commit 9f51e85 into master May 17, 2020
@pbiron pbiron deleted the enhance/copy-site-options-on-self-deactivation branch May 17, 2020 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants