Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add Better Handling to Ajax Errors #90

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Conversation

ronalfy
Copy link

@ronalfy ronalfy commented Apr 22, 2020

Resolves #87

This PR adds an inline error message when something fails, whether it's a capabilities check, or some other type of failure.

ajax-error-handling-plugins

themes-error-screen

@audrasjb audrasjb self-requested a review April 22, 2020 12:08
@ronalfy
Copy link
Author

ronalfy commented Apr 22, 2020

@audrasjb @pbiron

I combined all the ideas on #87 into this PR. Please weigh in with your comments/feedback.

Thanks!

Ronald Huereca

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @ronalfy !

@audrasjb audrasjb requested a review from pbiron April 22, 2020 12:10
@audrasjb audrasjb added the bug Something isn't working label Apr 22, 2020
@audrasjb audrasjb added this to the 0.6.0 milestone Apr 22, 2020
@ronalfy
Copy link
Author

ronalfy commented Apr 22, 2020

Here's an example of a generic message which is sent on failure (e.g., nonce failure, timeout):

nonce-failure

Copy link
Contributor

@pbiron pbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work.

@pbiron pbiron merged commit 2d36c0a into WordPress:master Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AJAX Error Handling
3 participants