Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks landing page: Example blocks could benefit from list arrangement #312

Open
alexstine opened this issue Aug 11, 2023 · 2 comments
Open
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Content Bugs or issues related to the page content [Section] Blocks /blocks, /gutenberg, related pages [Status] Needs Design Feedback Feedback is needed on an existing or new component

Comments

@alexstine
Copy link

From: #245

Page: https://wordpress.org/blocks
Heading 2: Build without limits

  1. Can probably remove the ALT text on the block icons. They are decretive and do not add value to the content. For example, Paragraph icon, Heading icon, etc. these do not tell users much or increase context in a meaningful way. If empty ALT is not optional, they can be left as is.
  2. I think a list presentation for these blocks would be better so that way screen readers get contextual information about how many blocks we'll be calling out here. It could be in a standard <ul> or <ol> if the numbers are not distracting.
@ryelle ryelle added Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Content Bugs or issues related to the page content labels Aug 12, 2023
ryelle added a commit that referenced this issue Aug 14, 2023
See #312 — Removes the alt text from decorative block icons.
@ryelle
Copy link
Contributor

ryelle commented Aug 14, 2023

I've removed the alt text from the icons.

I'm not sure if we can switch the markup to use a list and still keep the current visual design. @annezazu @SaxonF what do you think? Maybe you can try iterating with the list block?

@ryelle ryelle added the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Aug 14, 2023
@ryelle ryelle moved this to ⚠ On Hold/Blocked in WordPress.org Aug 14, 2023
@annezazu
Copy link

Thanks so much for diving in here and sharing feedback. The list block, in its current form and functionality, won't work for this afaik since it's sitting in a grid. Curious what Saxon thinks along with any other possible ideas.

Thank you @ryelle for updating the alt text! I added that and this is a good TIL for me.

@ryelle ryelle added the [Section] Blocks /blocks, /gutenberg, related pages label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Content Bugs or issues related to the page content [Section] Blocks /blocks, /gutenberg, related pages [Status] Needs Design Feedback Feedback is needed on an existing or new component
Projects
Status: On Hold/Blocked
Development

No branches or pull requests

3 participants