Unregister the global-styles from classic themes
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreymckrill
approved these changes
Feb 17, 2022
|
This has the side-effect of removing all the Tested by going to a page with the default styles, ex the "January" button on this page Keeping up with Gutenberg: Index 2022 .
|
dd32
added a commit
that referenced
this pull request
Feb 24, 2022
Deregistering the style will cause the style not to be output, but it will remain in the style stack and be detected as unoutputable at render time. By dequeueing the style first, it removes it from the stack to print. This fixes Query Monitor throwing a visual warning on classic themes. See #166, #86
ryelle
pushed a commit
that referenced
this pull request
Feb 24, 2022
Deregistering the style will cause the style not to be output, but it will remain in the style stack and be detected as unoutputable at render time. By dequeueing the style first, it removes it from the stack to print. This fixes Query Monitor throwing a visual warning on classic themes. See #166, #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86 — By default, Gutenberg outputs some basic presets (font sizes, colors, etc). The News theme overwrites a few of them (by virtue of using the same slugs), like font-sizes. In the header & footer, the font size is set to
--wp--preset--font-size--small, which should be 14px (set by News), but the defaultglobal-stylescode resets it to 13px on classic themes.The news styles output in
global-styles-for-classic-themesincludes the gutenberg default presets, so we can safely remove the second set of custom property definitions from classic themes.To test: