Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try setting the form border color to not be transparent #169

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Dec 19, 2024

When setting up styles for the search box, we set the form border color to be transparent, with 0 width. This has caused problems for inputs across the site, and we have added styles to child themes to overcome them.

See WordPress/wporg-make#55, the latest report for the Make handbooks. Make has had temporary fixes added to handle this, but those could be removed with this PR merged.

This PR sets the default form border properties to the values we use across the site, and introduces a new custom property for the search border width.

Screenshots

Before After
make wordpress org_photos_handbook_moderating-photos_(Desktop) (1) make wordpress org_photos_handbook_moderating-photos_(Desktop)

How to test the changes in this Pull Request:

  1. Build and load this branch in your sandbox or local environment
  2. Check various pages where forms and search forms exist, eg. https://make.wordpress.org/photos/handbook/moderating-photos/, https://wordpress.org/plugins/developers/add/, https://wordpress.org/showcase/submit-a-wordpress-site/
  3. The search form field wrapper should have no border, and the form input fields should have a border. You may need to toggle off child theme styles to see the parent styles in effect (definitely the case for Plugin directory, Make handbooks and Showcase).
  4. Test focus states

@adamwoodnz adamwoodnz marked this pull request as ready for review December 19, 2024 02:57
@adamwoodnz adamwoodnz self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 In review (PRs only)
Development

Successfully merging this pull request may close these issues.

1 participant