feat: Info Highlight Creation #3015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2024 11:18
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
info_highlight_creation
|
| Run status |
|
| Run duration | 02m 48s |
| Commit |
|
| Committer | niftea |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
923
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.37%
|
|
|---|---|
|
Untested elements
|
1510
|
|
Tested elements
|
408
|
Accessibility
99.15%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
162
|
added 2 commits
November 7, 2024 14:36
modules/preview-react/InformationHighlight/stories/visual_testing/testing.stories.tsx
Outdated
Show resolved
Hide resolved
|
Lets consolidate some of these examples:
These examples can be in one file, for example, |
|
We will also need to add some more information to each example and when to use each. When should a user use |
added 5 commits
December 10, 2024 13:04
|
This component is looking really good! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1175
Resolves: The need for an Information Highlight component. Moves the existing Information Highlight out of
modules/docsand intomodules/preview-react. Updates the existing design of Information Highlight to match the most recent specs and adding ahighandlowemphasis options.Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
/modules/react-preview/information-highlight/Areas for Feedback? (optional)
Testing Manually
yarn start to verify story book builds correctly, check out the new information highlight sections under preview, and testing preview
look at https://workday.github.io/canvas-kit/?path=/docs/tokens-tokens--docs in the local story book built by yarn start and verify the information highlight for tokens still builds and matches desired specs
Screenshots or GIFs (if applicable)
There are 6 style options for information highlight that come from a combination of two emphases and three variants. all six options have a colored side bar for the variant
High Emphasis Variants
Information Highlights also accept custom icons and properly tailor them for the variant and emphasis
They can also be built in a variety of ways with or without certain fields, the full extent of this can be seen in the visual testing
Thank You Gif (optional)