Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade storybook to 7.6.20 to fix vulnerabilities #3047

Merged
merged 2 commits into from
Nov 13, 2024
Merged

chore: Upgrade storybook to 7.6.20 to fix vulnerabilities #3047

merged 2 commits into from
Nov 13, 2024

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Nov 8, 2024 •
edited by NicholasBoll
Loading

Summary

There were a few security concerns in storybook. Although these seem to be fixed in 8.2 and later, we're still on 7.x. More info can be found here.

Release Category

Dependencies

Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

@cypress Cypress
Copy link

cypress bot commented Nov 8, 2024 •
edited
Loading

Workday/canvas-kit    Run #8036

Run Properties:  status check passed Passed #8036  •  git commit f5a1c2f169 ℹ️: Merge 352a233fa913d79333183a2642a40617666df2e4 into 802784764d4cd8f030cf5908d0c0...
Project Workday/canvas-kit
Branch Review mc-fix-storybook-vuln
Run status status check passed Passed #8036
Run duration 04m 01s
Commit git commit f5a1c2f169 ℹ️: Merge 352a233fa913d79333183a2642a40617666df2e4 into 802784764d4cd8f030cf5908d0c0...
Committer Manuel Carrera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 32
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1093
View all changes introduced in this branch ↗︎
UI Coverage  21.89%
  Untested elements 1632  
  Tested elements 455  
Accessibility  99.17%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 182  

@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label Nov 12, 2024
@NicholasBoll NicholasBoll added the dependencies Pull requests that update a dependency file label Nov 13, 2024
@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels Nov 13, 2024
@alanbsmith alanbsmith merged commit 648318a into Workday:master Nov 13, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasBoll NicholasBoll NicholasBoll approved these changes

Assignees
No one assigned
Labels
automerge dependencies Pull requests that update a dependency file
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mannycarrera4 @NicholasBoll @alanbsmith