Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve recast dep from jscodeshift to remove extra parens #3083

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: Resolve recast dep from jscodeshift to remove extra parens #3083

merged 1 commit into from
Dec 20, 2024

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Dec 20, 2024 •
edited
Loading

Summary

Fixes: #3084

Based on an open issue in jscodeshift, recast seems to be adding an extra parens in the return call in our unit tests. One of the suggested solutions was to downgrade recast. In v12, this has been fixed, but adding this resolution for v11.

Release Category

Dependencies

Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

@github-actions github-actions bot added the ready for review Code is ready for review label Dec 20, 2024
@mannycarrera4 mannycarrera4 changed the title fix: Resolve recast from jscodeshift to avoid extra parens error in t… fix: Resolve recast dep from jscodeshift to remove extra parens Dec 20, 2024
@mannycarrera4 mannycarrera4 marked this pull request as ready for review December 20, 2024 16:33
@cypress Cypress
Copy link

cypress bot commented Dec 20, 2024

Workday/canvas-kit    Run #8143

Run Properties:  status check passed Passed #8143  •  git commit a6add6dab0 ℹ️: Merge 373a2b147c5506186b901656858549ea3933b63b into 359d262385a8e4d2f510dd2f1dee...
Project Workday/canvas-kit
Branch Review refs/pull/3083/merge
Run status status check passed Passed #8143
Run duration 05m 26s
Commit git commit a6add6dab0 ℹ️: Merge 373a2b147c5506186b901656858549ea3933b63b into 359d262385a8e4d2f510dd2f1dee...
Committer Manuel Carrera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1006
View all changes introduced in this branch ↗︎

@alanbsmith alanbsmith merged commit 28f4c8e into Workday:support Dec 20, 2024
46 checks passed
@mannycarrera4 mannycarrera4 mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasBoll NicholasBoll NicholasBoll approved these changes

Assignees
No one assigned
Labels
automerge ready for review Code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mannycarrera4 @NicholasBoll @alanbsmith