Make JsBackedMap.values MSIE 11 compatible #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlademann-wf
force-pushed
the
5.5.0/polyfill-jsmap-values-for-ie11
branch
from
2ba955e
to
c66b92a
Compare
| @@ -38,7 +38,8 @@ class JsBackedMap extends MapBase<dynamic, dynamic> { | |||
|
|
|||
| // Private helpers with narrower typing than we want to expose, for use in other methods | |||
| List<dynamic> get _keys => _Object.keys(jsObject); | |||
| List<dynamic> get _values => _Object.values(jsObject); | |||
| // Use keys to access the value instead oof `Object.values` since MSIE 11 doesn't support it | |||
| List<dynamic> get _values => _keys.map((key) => this[key]).toList(); | |||
There was a problem hiding this comment.
I'd like to see us eventually polyfill Object.values on the JS side so that this can be potentially more optimized in browsers that support it, but this is totally fine for now
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.valuesis not supported in MSIE 11. We still have consumers that need to support the browser, so ourJsBackedMap.valuesimplementation needs to support it.Currently, if you access the
valuesgetter (as we do withinforwardRef), MSIE 11 will choke. This fixes that.@greglittlefield-wf