Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Workiva Build, move build steps since Travis which no longer runs #296

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

greglittlefield-wf
Copy link
Collaborator

No description provided.

@aviary2-wf
Copy link

aviary2-wf commented Jan 13, 2021

Security Insights

(2) Vulnerable direct dependencies were detected
  • 1 vulns in ini < 1.3.6 via package-lock.json
  • 1 vulns in node-fetch < 2.6.1 via package-lock.json
  • Action Items


    Questions or Comments? Reach out on Slack: #support-infosec.

    @semveraudit-wf
    Copy link

    semveraudit-wf commented Jan 13, 2021

    Public API Changes

    No changes to the public API found for commit c5162bb

    Showing results for c5162bb

    Powered by semver-audit-service. Please report any problems by filing an issue.
    Reported by the dart semver audit client 2.2.0
    Browse public API.

    Last edited UTC Jan 13 at 16:42:18

    @@ -40,11 +40,7 @@ mixin LifecycleTestHelper on Component {
    'context': context,
    });

    var lifecycleCallback = props == null
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This change was just due to dartfmt

    Copy link
    Collaborator

    @aaronlademann-wf aaronlademann-wf left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    +1

    Copy link
    Collaborator

    @joebingham-wk joebingham-wk left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    +10

    Changes look good and the build ran / passed all the steps!

    RUN pub run build_runner test --release -- --preset dart2js --exclude-tags=dart-2-7-dart2js-variadic-issues
    RUN pub run build_runner test -- --preset dartdevc

    RUN dart ./tool/run_consumer_tests.dart --orgName Workiva --repoName over_react --testCmd "pub run dart_dev test -P dartdevc"
    Copy link
    Collaborator

    @joebingham-wk joebingham-wk Jan 13, 2021

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Since Rosie supports this and the repo is now part of the Workiva ecosystem, should we nix this and set up consumer testing using Rosie? If not now, we could cut a ticket for it!

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yup, totally! I just included it since we had it in the old CI, and would have something in place until we set it up

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants