-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Workiva Build, move build steps since Travis which no longer runs #296
Conversation
Security Insights(2) Vulnerable direct dependencies were detectedini < 1.3.6 via package-lock.json node-fetch < 2.6.1 via package-lock.json Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Public API ChangesNo changes to the public API found for commit c5162bb Showing results for c5162bb
Last edited UTC Jan 13 at 16:42:18 |
@@ -40,11 +40,7 @@ mixin LifecycleTestHelper on Component { | |||
'context': context, | |||
}); | |||
|
|||
var lifecycleCallback = props == null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was just due to dartfmt
837dfe7
to
c5162bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
Changes look good and the build ran / passed all the steps!
RUN pub run build_runner test --release -- --preset dart2js --exclude-tags=dart-2-7-dart2js-variadic-issues | ||
RUN pub run build_runner test -- --preset dartdevc | ||
|
||
RUN dart ./tool/run_consumer_tests.dart --orgName Workiva --repoName over_react --testCmd "pub run dart_dev test -P dartdevc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Rosie supports this and the repo is now part of the Workiva ecosystem, should we nix this and set up consumer testing using Rosie? If not now, we could cut a ticket for it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, totally! I just included it since we had it in the old CI, and would have something in place until we set it up
No description provided.