-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin mockito 5 #355
Pin mockito 5 #355
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
5debe91
to
ca67b56
Compare
Skynet test results failed initially for this build but were approved by greg.littlefield |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Changes look good
- CI issues are expected and not directly related to this change, and can be addressed in a follow-up
+10
@Workiva/release-management-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Summary
Frontend Frameworks is updating dependencies! More details at
https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades
We've discovered that mockito 5.3.0 is not compatible with analyzer 2x.
So as we work to get repos upgraded to analyzer 2, mockito will start to fail
to compile. We can avoid this by setting an upper bound to avoid the known bad version.
mockito 5.3.1 and higher are ok, but require analyzer 4+
This batch will change the mockito dependency from ^5.0.0 to
'>=5.0.0 <5.3.0'
and may add a dependency_validator ignore for the pinned version of mockito
if neccessary.
A passing CI is sufficient QA (means mockito compiles and tests run).
For more info, reach out to Rob Becker in
#support-frontend-dx
Created by Sourcegraph batch change
Workiva/pin_mockito_5
.