Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mockito 5 #355

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Pin mockito 5 #355

merged 1 commit into from
Mar 9, 2023

Conversation

sourcegraph-wk
Copy link

Summary

Frontend Frameworks is updating dependencies! More details at
https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades

We've discovered that mockito 5.3.0 is not compatible with analyzer 2x.
So as we work to get repos upgraded to analyzer 2, mockito will start to fail
to compile. We can avoid this by setting an upper bound to avoid the known bad version.
mockito 5.3.1 and higher are ok, but require analyzer 4+

This batch will change the mockito dependency from ^5.0.0 to '>=5.0.0 <5.3.0'
and may add a dependency_validator ignore for the pinned version of mockito
if neccessary.

A passing CI is sufficient QA (means mockito compiles and tests run).

For more info, reach out to Rob Becker in #support-frontend-dx

Created by Sourcegraph batch change Workiva/pin_mockito_5.

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf marked this pull request as ready for review March 9, 2023 16:19
@autobot-wf
Copy link

Skynet test results failed initially for this build but were approved by greg.littlefield
https://wf-skynet-hrd.appspot.com/apps/test/smithy/4365707/1
Approval message: Ignoring these failures for now

Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes look good
  • CI issues are expected and not directly related to this change, and can be addressed in a follow-up

+10

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit b18b417 into master Mar 9, 2023
@rm-astro-wf rm-astro-wf deleted the batch/fedx/pin_mockito_5 branch March 9, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants