Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The default config sudachi.json sets non-existent property joinKanjiNumeric in JoinNumericPlugin #221

Closed
azagniotov opened this issue Feb 15, 2024 · 1 comment · Fixed by #222

Comments

@azagniotov
Copy link

azagniotov commented Feb 15, 2024

The default config src/main/resources/sudachi.json#L23-L24 which is bundled with Sudachi JAR v0.7.3, it passes non-existent property joinKanjiNumeric to the JoinNumericPlugin.java#L56-L59 which in fact uses enableNormalize property.

I guess this is not a huge issue because the default value of if the enableNormalize does not exist is true, which means Kanji numerics get normalized by default

@Override
    public void setUp(Grammar grammar) {
        enableNormalize = settings.getBoolean("enableNormalize", true);
        ...
    }

But, it would be great if this gets fixed in case if someone does not want to normalize.

@kazuma-t
Copy link
Member

Thank you for your report. This is an oversight in the improvement of the JoinNumericPlugin. I will make the necessary corrections.

kazuma-t added a commit that referenced this issue Feb 16, 2024
@kazuma-t kazuma-t linked a pull request Feb 16, 2024 that will close this issue
kazuma-t added a commit that referenced this issue Feb 16, 2024
…nfig-sudachijson-sets-non-existent-property-joinkanjinumeric-in-joinnumericplugin

Fix #221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants