Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync dump dict feature with Java version #277

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

mh-northlander
Copy link
Collaborator

@mh-northlander mh-northlander commented Nov 7, 2024

Synchronize the behavior of sudachi dump with Java version.

Output of sudachi dump [binary dictionary] winfo dumped_lex.csv will be equivalent to that of java -Dfile.encoding=UTF-8 -cp build/distributions/sudachi/sudachi-0.7.5.jar com.worksap.nlp.sudachi.d ictionary.DictionaryPrinter -o dumped_lex.csv [binary dictionary]

Also fix #274.

@mh-northlander mh-northlander merged commit d2b53d8 into develop Nov 11, 2024
8 checks passed
@mh-northlander mh-northlander deleted the feature/dump-dict branch November 11, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the first line of dump matrix lacks new line
2 participants