Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add additional wait after containers are healthy #27

Closed
benzht opened this issue Mar 11, 2024 · 4 comments
Closed

Feature: Add additional wait after containers are healthy #27

benzht opened this issue Mar 11, 2024 · 4 comments

Comments

@benzht
Copy link
Contributor

benzht commented Mar 11, 2024

I am having issues with some images that report 'ready' slightly before they are actually ready to do real business. One in particular would need just another few seconds to finish its infinispan-syncronisation (i.e., it is ready to sync, but not with the sync).

My proposal would be to define a switch like -g | --graceperiod SECONDS with default 0 and insert a suitable wait als else branch of this if [ "$SUCCESS" != "$SCALE" ]; then.

I can create a PR if that is desired.

Best regards

@wowu
Copy link
Owner

wowu commented Mar 11, 2024

I wonder what's the recommended way of configuring zero downtime deployment for your service, maybe it was designed for environments supporting multiple healthchecks like Kubernetes.

Anyway, contributions are always welcome 😃
I believe this is probably a niche use case so I wouldn't reserve a single letter flag for this. What do you think about --healthcheck-grace-period SECONDS? Or --wait-after-healthy SECONDS so it's similar to --wait SECONDS.

@benzht
Copy link
Contributor Author

benzht commented Mar 12, 2024

The root of my problem appears to be traefik doing it's own health checks and only a single container instance running.
When docker-rollout detects the new container 'healthy', but traefik still needs to detect it, then killing the old container will lead to disruption of service.
Please expect a PR (going for --wait-after-healthy)...

@wowu
Copy link
Owner

wowu commented Apr 3, 2024

Implemented in #28

@wowu wowu closed this as completed Apr 3, 2024
@wowu
Copy link
Owner

wowu commented Apr 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants