Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds --wait-after-healthy SECONDS allowing healthy container to… #28

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

benzht
Copy link
Contributor

@benzht benzht commented Mar 13, 2024

This PR adds #27 with a new switch --wait-after-healthy SECONDS.

When specified and rollout can see 'health' of containers, it adds an additional sleep to give the new container time to settle down and/or a reverse proxy to detect that the new container is healthy.

Copy link
Owner

@wowu wowu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docker-rollout Outdated Show resolved Hide resolved
@wowu
Copy link
Owner

wowu commented Apr 3, 2024

Tested, seems to be working correctly. Thank you for the contribution!

Close #27

@wowu wowu merged commit 2e87364 into wowu:main Apr 3, 2024
1 check passed
c4710n added a commit to c4710n/docker-compizo that referenced this pull request Jun 26, 2024
c4710n added a commit to c4710n/docker-compizo that referenced this pull request Jun 26, 2024
c4710n added a commit to c4710n/docker-compizo that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants