Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login is broken on WebKit based browsers #176

Open
pavelhoral opened this issue Jun 23, 2024 · 0 comments
Open

Login is broken on WebKit based browsers #176

pavelhoral opened this issue Jun 23, 2024 · 0 comments
Labels

Comments

@pavelhoral
Copy link
Member

Login on WebKit based browsers does not work due to aborted request in SessionValidator.js.

What happens is that:

  • after successful authentication with goto parameter, CommonConfig.js sets redirect URL via window.location.href
  • few lines above that EVENT_AUTHENTICATION_DATA_CHANGED event is fired which in turn fires EVENT_AUTHENTICATED
  • this starts session validation logic
  • from this point on the processing differs in WebKit browsers

In non-WebKit browsers:

  • session validation does not make any requests as the JS promise based processing is stopped after the navigation (setting window.location.href)

In WebKit browsers:

  • session validation makes the HTTP request for getSessionInfo, however that request gets cancelled (probably due to the navigation in progress)
  • SessionValidator is able to handle the request failure and navigates user to session expired error page

This issue started appearing probably after upgrading to newer jQuery with updated promise handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant