Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration audit logging (#33) #150

Conversation

fyrbach
Copy link
Member

@fyrbach fyrbach commented Aug 24, 2023

This PR adds missing audit logging of configuration changes when external config store is used.

The audit implementation was ported from SMSEmbeddedLdapObject.

This logging was missing for external config store.
@fyrbach fyrbach requested a review from pavelhoral August 24, 2023 07:58
Copy link
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fyrbach fyrbach linked an issue Aug 24, 2023 that may be closed by this pull request
@pavelhoral pavelhoral merged commit 467eafd into WrenSecurity:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration changes are not audited when using external config repo
2 participants