Upgrade wrensec-commons. Remove PowerMock dependency. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelhoral
reviewed
Sep 14, 2023
openam-core/src/test/java/org/forgerock/openam/services/email/MailServerImplTest.java
Outdated
Show resolved
Hide resolved
pavelhoral
reviewed
Sep 14, 2023
| @@ -44,7 +46,7 @@ public class CTSWorkerBaseProcessTest { | |||
| public void setUp() throws Exception { | |||
| mockQuery = mock(CTSWorkerQuery.class); | |||
| mockFilter = mock(CTSWorkerFilter.class); | |||
| mockProcess = mock(CTSWorkerBaseProcess.class); | |||
| mockProcess = spy(CTSWorkerBaseProcess.class); | |||
There was a problem hiding this comment.
Yes. We need to call the real method in the shouldUseQueryForNextPage test case (the mocked variant is not sufficient). The previous implementation worked because of different behaviour of the "PowerMock Mocker" (i think).
karelmaxa
force-pushed
the
upgrade-commons
branch
from
0335997 to
810be54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have upgraded the version of
wrensec-commonsto the latest SNAPSHOT with upgradedTestNGandJacksondependencies. ThePowerMocklibrary is not compatible with TestNG 7.5.0+ and does not appear to be maintained anymore. So I have removed the PowerMock library from the repository.I have successfully run our tests from the
wrenam-testrepository using the newly built version.