Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of SAML extensions #178

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

karelmaxa
Copy link
Member

This PR fixes the serialization of SAML extensions. According to the SAML 2 Metadata XML Schema, the extension is of the type Any. Therefore, it can be parsed as an instance of the JAXB object, but the current serialization process expects the value to be a simple string.

Copy link
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelhoral pavelhoral merged commit a3a2504 into main Sep 27, 2024
4 checks passed
@karelmaxa karelmaxa deleted the fix-saml-extension-serialization branch September 27, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants