Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for const enums #51

Merged
merged 3 commits into from
May 12, 2024

Conversation

AnthonyMichaelTDM
Copy link
Contributor

fixes #50

…ttings instead of uses_type_interface

This is done to allow us to encapulate "configuration" parameters to allow future contributors to more easily implement things such as what was requested in Wulf#50 without requiring them to change the trait further.
While neccessating minimal modifications to existing code.
also adds missing `./enum_numeric/tsync.sh` to ./test/test_all.sh
@AnthonyMichaelTDM AnthonyMichaelTDM marked this pull request as ready for review May 8, 2024 21:53
AnthonyMichaelTDM added a commit to AnthonyMichaelTDM/tsync that referenced this pull request May 8, 2024
uses the goldenfile crate to fail tests if the "goldenfile" is changed

merging will require updating both Wulf#53 (to add the tests to the CI) and  Wulf#51 (to add a test for const numeric enums), or if those are merged first then this will need to be updated.
@Wulf Wulf merged commit 890049b into Wulf:main May 12, 2024
@AnthonyMichaelTDM AnthonyMichaelTDM deleted the AnthonyMichaelTDM/issue50 branch May 12, 2024 23:05
AnthonyMichaelTDM added a commit to AnthonyMichaelTDM/tsync that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for const enums
2 participants