Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sneaking for glide #368

Closed
wants to merge 2 commits into from
Closed

fix sneaking for glide #368

wants to merge 2 commits into from

Conversation

Lamby777
Copy link

@Lamby777 Lamby777 commented Apr 9, 2021

Description

I originally intended to make this branch for fixing a bunch of issues with sneaking in certain hacks, but it would probably be too many, so I'm just gonna do 1 hack at a time. Today I added a new checkbox for Glide to temporarily disable the effects when crouching. It acts similar to pressing crouch in Creative Mode.

Copy link

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

@Lamby777
Copy link
Author

still important, though idr if this got added by other people later on anyway

@Alexander01998
Copy link
Member

Hey @Lamby777,

Thanks for the reminder! Just had a look, and it seems like this PR has some significant conflicts and formatting issues that need to be resolved before it's ready for a merge.

If the sneaking fix hasn't been added by anyone else yet and you still believe it's important, I encourage you to resolve those conflicts and tidy up the formatting. Once that's done, give me a shout and I'll take another look at it.

@Lamby777
Copy link
Author

Lamby777 commented Jan 1, 2024

Hey @Lamby777,

Thanks for the reminder! Just had a look, and it seems like this PR has some significant conflicts and formatting issues that need to be resolved before it's ready for a merge.

If the sneaking fix hasn't been added by anyone else yet and you still believe it's important, I encourage you to resolve those conflicts and tidy up the formatting. Once that's done, give me a shout and I'll take another look at it.

Yeah, it's been a while since I posted this, and back then I remember formatting issues were a huge pain because they'd always cause massive merge conflicts, so thanks for adding that one formatter in the build process (forgot what it's called, "spotless" or something)

@Lamby777
Copy link
Author

Lamby777 commented Jan 3, 2024

I think this PR was made from a different repo I have since deleted, and not the other fork I currently work on... If I'm getting this right, you can't change a PR's source branch, so I made a new PR for this. Turns out the feature was mostly already re-implemented on this fork, but I forgot to add the addSetting call for the new checkbox... :/

image

@Lamby777 Lamby777 closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants