Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 Checklist #149

Closed
7 tasks done
Wykks opened this issue May 28, 2019 · 6 comments
Closed
7 tasks done

V5 Checklist #149

Wykks opened this issue May 28, 2019 · 6 comments

Comments

@Wykks
Copy link
Owner

Wykks commented May 28, 2019

Configurable NgZone behavior (and run mapbox-gl Inside NgZone by default, instead of outside). Some design inspiration here: https://github.com/ngxs/store/tree/master/packages/store/src/execution

ETA: Aborted. Looks like only very few peoples have issues with mapbox-gl running outside NgZone by default. And in this case, it's just a call to ngZon.run().

ETA : Done for image source in v3.3.0. Reported for the next major version
PR welcome

  • Move doc to repositoy (create a doc directory and create markdown file there)
    -> add a way to select major version to access old doc in showcase app (using git branch)

ETA: Will do, required for v5.0 (at least the doc inside the repo, showcase can be done later).

ETA: Will do, required for v5.0

ETA: PR welcome, required for v4.0

@BernhardRode
Copy link
Contributor

BernhardRode commented May 29, 2019

I've just updated my app to:

  • "@angular/animations": "^8.0.0",
  • "@angular/common": "^8.0.0",
  • "@angular/compiler": "^8.0.0",
  • "@angular/core": "^8.0.0",
  • "@angular/forms": "^8.0.0",
  • "@angular/platform-browser": "^8.0.0",
  • "@angular/platform-browser-dynamic": "^8.0.0",
  • "@angular/router": "^8.0.0",
  • [...]
  • "mapbox-gl": "^1.0.0",
  • [...]
  • "ngx-mapbox-gl": "^3.1.0",
  • [...]

Everything worked like a charm for me. But i'm not using all of ngx-mapbox-gl features. But I think 2 and 3 should not give many problems =)

@Wykks
Copy link
Owner Author

Wykks commented Jun 2, 2019

Some ETA (because I probably won't make it in short term..):
Worked on new component api "markers-of-clusters" (using external geojson source). Looks good :)

Nothing else for now. It's "hard" for me to work on this: I'm not using mapbox-gl anymore (don't have use case atm), and I have other stuff to do in my spare time.

PR are welcome by the way 😄

@SamuelDev
Copy link

We are using Angular 6 and Mapbox 1.0.0. Will V4 work with Angular 6 still, or will it only support 8?

@Wykks
Copy link
Owner Author

Wykks commented Jun 6, 2019

Hi!

v4 will target Angular 8 (and 9).

What kind a feature do you want ?
New marker cluster component will available in v3 (#151).

I hesitate to add support of mapbox-gl 1.0 (new features in particular) in v3, because there are some breaking changes, so in theory I can only add it in v4.
But these breaking change probably wont affect most of users so... Dunno...

(It's super easy to upgrade Angular with ng update you know 😛 )

@dmytro-gokun
Copy link
Collaborator

@Wykks Please let me know what issue(s) you'd like to have a PR for. I'd like help speeding up V4 arrival, but do not like stepping on someone else's foot by working on the same issue in parallel :)

@Wykks
Copy link
Owner Author

Wykks commented Jul 19, 2019

Post updated :)
I'll keep this updated if I start working on "PR welcome" tasks.
Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants