-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5 Checklist #149
Comments
I've just updated my app to:
Everything worked like a charm for me. But i'm not using all of ngx-mapbox-gl features. But I think 2 and 3 should not give many problems =) |
Some ETA (because I probably won't make it in short term..): Nothing else for now. It's "hard" for me to work on this: I'm not using mapbox-gl anymore (don't have use case atm), and I have other stuff to do in my spare time. PR are welcome by the way 😄 |
We are using Angular 6 and Mapbox 1.0.0. Will V4 work with Angular 6 still, or will it only support 8? |
Hi! v4 will target Angular 8 (and 9). What kind a feature do you want ? I hesitate to add support of mapbox-gl 1.0 (new features in particular) in v3, because there are some breaking changes, so in theory I can only add it in v4. (It's super easy to upgrade Angular with |
@Wykks Please let me know what issue(s) you'd like to have a PR for. I'd like help speeding up V4 arrival, but do not like stepping on someone else's foot by working on the same issue in parallel :) |
Post updated :) |
Configurable NgZone behavior (and run mapbox-gl Inside NgZone by default, instead of outside). Some design inspiration here: https://github.com/ngxs/store/tree/master/packages/store/src/execution
ETA: Aborted. Looks like only very few peoples have issues with mapbox-gl running outside NgZone by default. And in this case, it's just a call to ngZon.run().
More info: Changing mgl-image-source coordinates dynamically causes issues #139 (comment)
ETA : Done for image source in v3.3.0. Reported for the next major version
PR welcome
-> add a way to select major version to access old doc in showcase app (using git branch)
ETA: Will do, required for v5.0 (at least the doc inside the repo, showcase can be done later).
ETA: Will do, required for v5.0
-> Activate this http://codelyzer.com/rules/no-output-native/
ETA: PR welcome, required for v4.0
The text was updated successfully, but these errors were encountered: