-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing mgl-image-source coordinates dynamically causes issues #139
Comments
In lots of Inputs of source, I'm doing a
I knew this was not super smart 😅 |
Note: there's a new |
@Wykks As far as i can see. for imageSource there are some methods to update it after creation: https://docs.mapbox.com/mapbox-gl-js/api/#imagesource |
Yep I was refering to that in my previous post :) Other components probably don't have a magical update method (I searched them before making this bad pattern), so I guess we can only changes input from dynamic to init only (for v4). |
@Wykks Yep, i'll try to work on this shortly |
I'm having the same issue as @HarelM at #10 with only difference that I'm using 'mgl-image-source' and changing the coordinates dynamically.
So after doing this in my component
it throws me these errors
Source "floorplanImageSource" cannot be removed while layer "floorplanImageLayer" is using it.
And then
There is already a source with this ID
Originally posted by @sprattek in #10 (comment)
The text was updated successfully, but these errors were encountered: