Changing mgl-image-source coordinates dynamically causes issues

[sprattek]

I'm having the same issue as @HarelM at #10 with only difference that I'm using 'mgl-image-source' and changing the coordinates dynamically.

<mgl-image-source
  id="floorplanImageSource"
  [url]="floorplanImageSourceOptions.url"
  [coordinates]="floorplanImageSourceOptions.coordinates"
></mgl-image-source>
<mgl-layer
  id="floorplanImageLayer"
  source="floorplanImageSource"
  type="raster"
  [paint]="floorplanImageLayerOptions.paint"
  [layout]="floorplanImageLayerOptions.layout"
></mgl-layer>

So after doing this in my component

this.floorplanImageSourceOptions.coordinates = newCoodinates

it throws me these errors

Source "floorplanImageSource" cannot be removed while layer "floorplanImageLayer" is using it.
And then There is already a source with this ID

Originally posted by @sprattek in #10 (comment)

[Wykks]

In lots of Inputs of source, I'm doing a

this.ngOnDestroy();
this.ngOnInit();

I knew this was not super smart 😅
I don't remember when mapbox-gl did this change but yep, it doesn't work anymore.
I'll try to find a way around this or simply move theses inputs as "Init inputs" only.

[Wykks]

Note: there's a new updateImage method, in mapbox-gl v0.54.0 (mapbox/mapbox-gl-js#7999). I'll update the image component accordingly. (the image component is one of the few component using this bad pattern destroy/init).

[dmytro-gokun]

@Wykks As far as i can see. for imageSource there are some methods to update it after creation: https://docs.mapbox.com/mapbox-gl-js/api/#imagesource
I'll try to use those.

[Wykks]

Yep I was refering to that in my previous post :)
Not sure to have the time this week, so would be great if you can take a look.

Other components probably don't have a magical update method (I searched them before making this bad pattern), so I guess we can only changes input from dynamic to init only (for v4).

[dmytro-gokun]

@Wykks Yep, i'll try to work on this shortly