Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ATTR_cockpit_lit_only #595

Closed
3 tasks done
tngreene opened this issue Sep 29, 2020 · 1 comment
Closed
3 tasks done

Support ATTR_cockpit_lit_only #595

tngreene opened this issue Sep 29, 2020 · 1 comment
Assignees
@tngreene
Labels
Feature priority high
Milestone
v4.1.0-alpha.1

Comments

@tngreene
Copy link
Contributor

tngreene commented Sep 29, 2020 •
edited
Loading

This is a non parameter header (despite not having GLOBAL_ as a prefix) directive that should have a single checkbox in XPlaneLayer.

  • Property, UI, bump version number
  • Unit test "does it exist or not" and "trying to use this when export type is not cockpit doesn't work (UI should hide this)
  • Code
@tngreene tngreene added this to the v4.1.0-beta.1 milestone Sep 29, 2020
@tngreene tngreene self-assigned this Sep 29, 2020
@tngreene
Copy link
Contributor Author

tngreene commented Oct 5, 2020

Not really related but it has a similar name so in case if I click on this and meant #481, ATTR_cockpit_device, there's the link

tngreene added a commit that referenced this issue Oct 27, 2020
@tngreene
Closes #595, with unit test, code, and all that fun!
9bc8ac7
@tngreene tngreene mentioned this issue Nov 4, 2020
Closed
tngreene added a commit that referenced this issue Nov 5, 2020
@tngreene
Closes #595! However, in working on this bug it was discovered that t…
b1b9adc 
…he regions feature is quite possibly broken, and that we don't have test coverage for it! Also discovered is that Aircraft export types have been previously unable to work with regions. Bug reports made.
@tngreene tngreene modified the milestones: v4.1.0-beta.1, v4.1.0-alpha.1 Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tngreene tngreene

Labels
Feature priority high
Projects
None yet
Milestone
v4.1.0-alpha.1
Development

No branches or pull requests
1 participant
@tngreene