refactor: js bindings #209
Conversation
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 296 296
=========================================
Hits 296 296 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/jsapi/export_configure.cc
Outdated
| @@ -1,4 +1,4 @@ | |||
| #include "configure.h" | |||
| #include "include/export_configure.h" | |||
There was a problem hiding this comment.
这个 include 目录不是公开 api 吧，这样按照惯例直接和 cc 文件放一起就可以了吧？
There was a problem hiding this comment.
放一起会不会文件太多了，内部的非公开 include 目录有啥约定么，还是惯例就是全部平铺开的
There was a problem hiding this comment.
现在把 jsapi 的声明统一放到 src/jsapi/jsapi.h 了，去掉了 include 目录以及拆分的每一个 jsapi 的头文件，这样子似乎清晰一些，毕竟内容并不多
There was a problem hiding this comment.
铺平的吧，按照模块分文件夹就好了。最好还是声明和实现用同一个名字的文件，比如 a.h 里声明的在 a.cc 里实现，这样不需要借助 ide、搜索就能比较方便定位代码。
There was a problem hiding this comment.
改回来了，现在是铺平，然后头文件和实现名称保持一致
Commits: - [bfe59c1] feat: support http profiling (#215) - [85065b8] refactor: config (#214) - [ea2e7f8] fix: avoid copying constant strings (#212) - [5b157fe] fix: remove unused dump action field (#211) - [840df2a] refactor: consolidate dump actions (#210) - [289770f] refactor: js bindings (#209) PR-URL: #216
将所有的 JS Binding 收敛到
src/jsapi目录，方便后续统一增加管理。此 PR 不涉及到逻辑改动，依靠 JS 单测保证逻辑兼容。
Reference：#27