feat: support auto increase heap limit #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barretlee
reviewed
Jan 10, 2023
| namespace xprofiler { | ||
| static const char module_type[] = "heap_limit"; | ||
|
|
||
| size_t NearHeapLimitCallback(void* data, size_t current_heap_limit, |
There was a problem hiding this comment.
不需要，limit 其实只是一个值，它除了让 v8 判断是否需要 OOM，不会反映到实际内存上的
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 317 318 +1
=========================================
+ Hits 317 318 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
增加
enable_auto_incr_heap_limit的配置，默认为false即不开启此特性。如果开启
enable_auto_incr_heap_limit为true，则会使得 Node.js 进程在堆分配即将到达上限时可以自动增加heap_limit续命。默认每次接近堆上限增加
256MB的heap_limit，这个值可以通过auto_heap_limit_size来进行修改。TODO
等到 Node.js 进程内存水位恢复正常后使用
RemoveNearHeapLimitCallback重设heap_limit为initial_heap_limit