NITWORK/SERVER-NETWORK: Fix wrong implementation of tick and receiveClientEnemyDeath

src/Nitwork/ANitwork.cpp

@@ -60,7 +60,7 @@ namespace Nitwork {
         _clockThread = std::thread([this, tick]() {
             try {
                 while (_isRunning) {
-                    std::this_thread::sleep_for(std::chrono::milliseconds(tick));
+                    std::this_thread::sleep_for(std::chrono::milliseconds(TICKS_PER_MILLISECOND(tick)));
                     _tickMutex.lock();
                     _tickConvVar.notify_all();
                     _tickMutex.unlock();

src/Nitwork/Nitwork.h

@@ -12,8 +12,9 @@
     #include "MessageTypes.h"
 
     #define HEADER_SIZE sizeof(struct header_s)
-    #define TICKS_PER_SECOND 60
-    #define ONE_SECOND 1000
+    #define TICKS 128
+    #define TICKS_PER_SECOND(t) (t / TICKS)
+    #define TICKS_PER_MILLISECOND(t) (TICKS_PER_SECOND(t) / 1000)
     #define DEFAULT_THREAD_NB 4
     #define MAX_NB_ACTION 16
     #define HEADER_CODE1 '\x01'

src/Nitwork/NitworkClient.hpp

@@ -26,7 +26,7 @@ namespace Nitwork {
                 int port,
                 const std::string &ip,
                 int threadNb = DEFAULT_THREAD_NB,
-                int tick     = TICKS_PER_SECOND);
+                int tick     = TICKS);
 
             // Messages creation methods
             void addInitMsg();

src/Nitwork/NitworkServer.hpp

@@ -21,11 +21,7 @@ namespace Nitwork {
 
             static NitworkServer &getInstance();
 
-            bool startServer(
-                int port,
-                int nbPlayer,
-                int threadNb = DEFAULT_THREAD_NB,
-                int tick     = TICKS_PER_SECOND);
+            bool startServer(int port, int nbPlayer, int threadNb = DEFAULT_THREAD_NB, int tick = TICKS);
 
             /* Messages creation methods */
             void addStarWaveMessage(boost::asio::ip::udp::endpoint &endpoint, n_id_t enemyId);

src/Server/Systems/Network/ServerNetwork.cpp

@@ -49,26 +49,25 @@ namespace Systems {
         auto &arrEnemies = registry.getComponents<Types::Enemy>();
         auto arrHealth   = registry.getComponents<struct health_s>();
         auto arrPos      = registry.getComponents<Types::Position>();
-        auto it = std::find_if(arrEnemies.begin(), arrEnemies.end(), [&msgEnemyDeath](auto &enemy) {
-            return enemy.getConstId().id == msgEnemyDeath.enemyId.id;
-        });
-        if (it == arrEnemies.end()) {
-            return;
-        }
-        auto index = std::distance(arrEnemies.begin(), it);
-        if (!arrEnemies.exist(index) || !arrHealth.exist(index) || !arrPos.exist(index)) {
-            return;
+        auto ids         = arrEnemies.getExistingsId();
+
+        for (auto &id : ids) {
+            if (arrEnemies[id].getConstId().id == msgEnemyDeath.enemyId.id) {
+                if (arrHealth.exist(id) && arrPos.exist(id)) {
+                    Nitwork::NitworkServer::getInstance().addNewEnemyMessage(
+                        endpoint,
+                        {
+                            .id   = arrEnemies[id].getConstId(),
+                            .life = arrHealth[id],
+                            .pos =
+                                {static_cast<char>(Maths::removeIntDecimals(arrPos[id].x)),
+                                      static_cast<char>(Maths::removeIntDecimals(arrPos[id].y))},
+                            .type = arrEnemies[id].type,
+                    });
+                }
+                return;
+            }
         }
-        Nitwork::NitworkServer::getInstance().addNewEnemyMessage(
-            endpoint,
-            {
-                .id   = arrEnemies[index].getConstId(),
-                .life = arrHealth[index],
-                .pos =
-                    {static_cast<char>(Maths::removeIntDecimals(arrPos[index].x)),
-                          static_cast<char>(Maths::removeIntDecimals(arrPos[index].y))},
-                .type = arrEnemies[index].type,
-        });
     }
 
     void receiveNewBulletMsg(const std::any &msg, boost::asio::ip::udp::endpoint &endpoint)

src/main_client.cpp

@@ -47,7 +47,7 @@ int main(int ac, const char **av)
     }
     auto &sceneManager = Scene::SceneManager::getInstance();
     if (!Nitwork::NitworkClient::getInstance()
-             .startClient(std::stoi(av[2]), av[1], DEFAULT_THREAD_NB, TICKS_PER_SECOND)) {
+             .startClient(std::stoi(av[2]), av[1], DEFAULT_THREAD_NB, TICKS)) {
         return EXIT_EPITECH;
     }
     Nitwork::NitworkClient::getInstance().addInitMsg();

src/main_server.cpp

@@ -53,7 +53,8 @@ int main(int ac, const char **av)
         return EXIT_EPITECH;
     }
     Logger::info("Starting Server...");
-    if (!Nitwork::NitworkServer::getInstance().startServer(std::stoi(av[1]), std::stoi(av[2]))) {
+    if (!Nitwork::NitworkServer::getInstance()
+             .startServer(std::stoi(av[1]), std::stoi(av[2]), DEFAULT_THREAD_NB, TICKS)) {
         return EXIT_EPITECH;
     }
     auto &director = Systems::SystemManagersDirector::getInstance();