-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCUMENTATION: Add bullet doc #123
Conversation
WalkthroughThis change introduces a new section in the developer guide about bullet properties in the game, and modifies the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (2)
- docs/SUMMARY.md (1 hunks)
- docs/developer-guide/ecs/bullets.md (1 hunks)
Files skipped from review due to trivial changes (2)
- docs/SUMMARY.md
- docs/developer-guide/ecs/bullets.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- src/Nitwork/ANitwork.hpp (1 hunks)
Additional comments (Suppressed): 2
src/Nitwork/ANitwork.hpp (2)
- 66-67: The change from a single line to two lines for creating the
compressedPacket
shared pointer improves readability. However, it's important to note that theZstd::compress(data)
function may throw an exception if the compression fails. It would be better to handle this potential exception to prevent the program from crashing.try { std::shared_ptr<std::vector<char>> compressedPacket = std::make_shared<std::vector<char>>(Zstd::compress(data)); } catch (const std::exception& e) { // Handle the exception appropriately }
- 69-70: The asynchronous send operation is not guaranteed to send all data in one call. It's recommended to handle the case where only part of the data is sent. Also, the lifetime of the
compressedPacket
must be managed to ensure it remains valid until the async operation completes. Consider using a class member to store thecompressedPacket
or use a custom handler to manage its lifetime.
MINOR
What is the current behavior? (link an issue based on the kind of change this pr introduce)
What is the new behavior (if this is a feature change)?
Other information:
Summary by CodeRabbit