Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rb 59 parallax system #48

Merged
merged 26 commits into from
Oct 6, 2023
Merged

Feature/rb 59 parallax system #48

merged 26 commits into from
Oct 6, 2023

Conversation

KitetsuK
Copy link
Collaborator

@KitetsuK KitetsuK commented Oct 4, 2023 •
edited
Loading

PATCH

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)

  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?

  • Other information:

@KitetsuK KitetsuK self-assigned this Oct 5, 2023
@KitetsuK KitetsuK added the enhancement New feature or request label Oct 5, 2023
guillaumeAbel
guillaumeAbel requested changes Oct 5, 2023
View reviewed changes
assets/Json/parallaxData.json Outdated Show resolved Hide resolved
assets/Json/playerData.json Outdated Show resolved Hide resolved
deps/json/CMakeLists.txt Outdated Show resolved Hide resolved
Saverio976
Saverio976 requested changes Oct 5, 2023
View reviewed changes
src/ECS/Systems/Managers/SystemManager.cpp Outdated Show resolved Hide resolved
src/ECS/Systems/Managers/SystemManager.hpp Outdated Show resolved Hide resolved
src/ECS/Systems/Systems.cpp Outdated Show resolved Hide resolved
src/ECS/Systems/Systems.cpp Outdated Show resolved Hide resolved
guillaumeAbel
guillaumeAbel requested changes Oct 5, 2023
View reviewed changes
src/ECS/Systems/Systems.cpp Outdated Show resolved Hide resolved
@guillaumeAbel guillaumeAbel merged commit dcd01fd into dev Oct 6, 2023
12 checks passed
@Saverio976 Saverio976 deleted the feature/RB-59-parallax-system branch October 10, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumeAbel guillaumeAbel guillaumeAbel approved these changes

@Saverio976 Saverio976 Awaiting requested review from Saverio976

Assignees

@KitetsuK KitetsuK

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KitetsuK @Saverio976 @guillaumeAbel