Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-network: Add send bullet function into bullet creation system #68

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Server-network: Add send bullet function into bullet creation system #68

merged 5 commits into from
Oct 10, 2023

Conversation

romainpanno
Copy link
Collaborator

@romainpanno romainpanno commented Oct 10, 2023 •
edited
Loading

MINOR

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)

  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?

  • Other information:

@romainpanno romainpanno self-assigned this Oct 10, 2023
@romainpanno romainpanno added the enhancement New feature or request label Oct 10, 2023
TTENSHII
TTENSHII requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@TTENSHII TTENSHII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix windows compilation

@guillaumeAbel guillaumeAbel merged commit 1d0c8c8 into dev Oct 10, 2023
12 checks passed
@Saverio976 Saverio976 deleted the feature/RB-86-system-send-bullet branch October 17, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TTENSHII TTENSHII TTENSHII requested changes

@guillaumeAbel guillaumeAbel guillaumeAbel approved these changes

@Saverio976 Saverio976 Awaiting requested review from Saverio976

Assignees

@romainpanno romainpanno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romainpanno @TTENSHII @guillaumeAbel