Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v0.30.0 #449

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 24, 2023

🤖 New release

  • octocrab: 0.29.3 -> 0.30.0 (⚠️ API breaking changes)

⚠️ octocrab breaking changes

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-check/tree/v0.22.1/src/lints/struct_missing.ron

Failed in:
  struct octocrab::models::webhook_events::payload::CommitComment, previously in file /tmp/.tmpGzP1x8/octocrab/src/models/webhook_events/payload/commit_comment.rs:25
Changelog

0.30.0 - 2023-09-01

Other

  • Fix commit_comment webhook event parsing (#453)
  • Add Octocrab::users() and UsersHandler::repos (#451)
  • Add CommitHandler::associated_check_runs (#450)
  • Fix installation token cache issue (#442)
  • Add projects Api (#447)
  • Enhance installation webhook events
  • Add test for push webhook event
  • Implement custom deserialization for hybrid Github API timestamps
  • Make webhook_events deserialization tests more robust


This PR was generated with release-plz.

@github-actions github-actions bot force-pushed the release-plz/2023-08-24T16-47-59Z branch 2 times, most recently from 58b794c to 67b1422 Compare August 24, 2023 17:24
@gagbo
Copy link
Contributor

gagbo commented Aug 25, 2023

Note: it's weird that the changeset is not considered a breaking change and bumped to 0.30.0:

In this commit I changed models::webhook_events::InstallationWebhookEventPayload::repositories from Vec<_> to Option<Vec<_>>, even had to change the tests to make the old version compile. And if I didn't miss anything, this field is part of the public API of the crate (at least, it should be and that's a bug if the field is not exposed)

@XAMPPRocky
Copy link
Owner

XAMPPRocky commented Aug 25, 2023

Note: it's weird that the changeset is not considered a breaking change and bumped to 0.30.0

There are limitations to cargo-semver-checks and this is one of them, thanks for flagging, it I'll set it to 0.30.0 in the PR before merging.

@github-actions github-actions bot force-pushed the release-plz/2023-08-24T16-47-59Z branch 2 times, most recently from c2bb68c to 333ba49 Compare August 31, 2023 17:05
@github-actions github-actions bot changed the title chore: release v0.29.4 chore: release v0.30.0 Sep 1, 2023
@github-actions github-actions bot force-pushed the release-plz/2023-08-24T16-47-59Z branch from 333ba49 to 3eb043a Compare September 1, 2023 14:36
@XAMPPRocky XAMPPRocky merged commit 03103f5 into main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants