feat: add methods to builder for changing timeouts #498
Conversation
johnrichardrinehart
force-pushed
the
fix/configurable_timeouts
branch
from
95d713a
to
10479e0
Compare
johnrichardrinehart
force-pushed
the
fix/configurable_timeouts
branch
from
10479e0
to
a586def
Compare
src/lib.rs
Outdated
| @@ -485,6 +485,27 @@ impl OctocrabBuilder<NoSvc, DefaultOctocrabBuilderConfig, NoAuth, NotLayerReady> | |||
| self | |||
| } | |||
|
|
|||
| /// Set the connect timeout. | |||
| #[cfg(feature = "timeout")] | |||
There was a problem hiding this comment.
Does this really need its own feature flag? I think it's probably better to just have it included by default.
There was a problem hiding this comment.
I don't know. But, much of the timeout functionality is already guarded behind the timeout feature flag. I figured it'd be good to keep it in order to keep things consistent and to clean up the compiled output.
Note that I don't know what value it would provide users. If this code isn't guarded behind the timeout flag since then users who are not using the timeout flag will see methods that won't be of any use to them.
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
|
@XAMPPRocky I think the feature flag mentioned above is indeed required: I think reverting f1c94c1 does fix this issue. |
Work related to #497 .