Repairing two 204-related serde errors, and adding some simple tests. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding a custom FromResponse handler for 204s - It uses the `octocrab::_delete()` function, though, which seems like a bad idea. - The tests do all pass, including the one I added, though. Feedback and other ideas are welcome. In general, I think we need a new approach to the 204 responses. I kinda think the `delete()` function needs a minor re-factor, but I worry that that might have some breaking changes and common-law features.
- These tests pass. - I still don't like the fix.
manchicken
changed the title
|
@XAMPPRocky, I think this is ready for review. |
|
Thank you for your PR! |
Merged
|
Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
octocrab.issues().delete_label()octocrab.teams().repos().remove()Other
octocrab.teams().repos().add_or_update()octocrab.issues().remove_label()This PR is for issue #504.