Add super elliptical fiducial volumes for testing in SR1

[sanderbreur]

This commit adds the code to test the 31 optimized super elliptical FV shapes for testing. The values and construction of the shapes can be found in: https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenon1t:analysis:sciencerun1:fiducial_volume:optimized_ellips

An analyst can now use LAX to do:
FiducialTestEllips1000().process(df) to add the Boolean row for a 1000 kg super ellips. Or do FiducialTestEllips1425().process(df) for the 1425 kg super ellips. All available fiducial volumes are between 1000-1700 kg in steps of 25 kg.

To keep the code clean I chose a method (thanks Jelle) that builds all classes from a single list of inputs instead of copy pasting 31 different classes with only different values. The class name is changed for every mass to make it clear to the analyst what they are using.

Enjoy!

[pdeperio]

Thanks Sander. Could this be implemented in SR0 instead and inherited in SR1?

Please check codacy errors. You can check and fix locally now (or prior to committing next time) with:

flake8  --ignore E501 lax/lichens/sciencerun*.py
# check output here as next line will modify them all

autopep8 -i --ignore E501 lax/lichens/sciencerun*.py

[sanderbreur]

Dear Patrick, Thanks for the comments. Just implementing it in SR0 and inheriting in SR1 will not work for this cut due to the method of creating the class names. If we really wants to do that it would mean the whole part should be moved to a new file and then the whole file could be imported by both. But that would mean changing the way we manage cuts in LAX. Once we choose which one we use this can of course be solved, but right now we have to either put it in SR0 or SR1. The codacy issues have been solved. Cheers, Sander Op wo 22 nov. 2017 om 15:26 schreef Patrick de Perio < notifications@github.com>:

…

Thanks Sander. Could this be implemented in SR0 instead and inherited in SR1? Please check codacy errors. You can check and fix locally now (or prior to committing next time) with: flake8 --ignore E501 lax/lichens/sciencerun0.py # check output here as next line will modify them all autopep8 -i --ignore E501 lax/lichens/sciencerun0.py — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#100 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGNstUAPPM9KV86mOmXlpqbvTDT6TPxUks5s5C6egaJpZM4Qndpd> .

[pdeperio]

ok, how about duplicating the code in SR0 for now, and think about refactoring later?

[sanderbreur]

Ok, done.

[sanderbreur]

Ok, yes, done Op wo 22 nov. 2017 om 16:23 schreef Patrick de Perio < notifications@github.com>:

…

ok, how about duplicating the code in SR0 for now, and think about refactoring later? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#100 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGNstWm1kIJ0VF9DZ_bNpg_Gjjwj-XWpks5s5Dx6gaJpZM4Qndpd> .