Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in FV z-optimization analysis #145

Merged
merged 4 commits into from
Feb 26, 2018
Merged

Fix bug in FV z-optimization analysis #145

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e0ebe9
Re-optimize z-cut based on bug fix FV analysis
pdeperio Feb 25, 2018
c7fc2a5
Add z-cut on bottom-right corner of FV
pdeperio Feb 25, 2018
9e9eeeb
Add max R cut
pdeperio Feb 25, 2018
b310e3a
Little more fine-tuning from more bug fixes
pdeperio Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lax/lichens/sciencerun0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,10 @@ class FiducialZOptimized(StringLichen):

https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenon1t:analysis:sciencerun1:summary_fiducial_volume
"""
version = 0
string = "(-95 < z_3d_nn) & (z_3d_nn < -7) & \
(z_3d_nn < 27.2929 - 0.0276385*r_3d_nn*r_3d_nn)"
version = 1
string = "(-95 < z_3d_nn) & (z_3d_nn < -8) & \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the R cut?

Copy link
Contributor

@coderdj coderdj Feb 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's logical 'and' between all 4 lines.

Edit: I think you're right. Max r is missing... also in the last version right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 9e9eeeb: r_3d_nn < 42.8387

(z_3d_nn < 6.1863 - 0.0154508*r_3d_nn*r_3d_nn) & \
(z_3d_nn > -157.727 + 0.0407326*r_3d_nn*r_3d_nn)"


FV_CONFIGS = [
Expand Down