Update S2Width Cut #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the S2Width Cut, which is formulated according to Chi2 distribution. [Note](https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenon1t:sim:notes:tzhu:width_cut_tuning#toy_fax_simulation)
sreichard
approved these changes
Nov 15, 2017
pdeperio
suggested changes
Nov 15, 2017
Update SR0 S2 width using the chi2 model, also update S1SingleScatter, since it's using the S2Width Cut
1) Make all science run dependent variables as class attributes of S2Width, so that they can be called by self dot, and doing so without a explicit class constructor. 2) By doing 1) we can make S2Width class a class attribute of S1SingleScatter, which carries all the run dependent variables as its own class attributes. 3) So that in sciencerun1 lichens, we can simply inherit the sr0 classes (and becomes their own class) and reassign those few class attributes, and no need for changing any methods.
pdeperio
reviewed
Nov 15, 2017
lax/lichens/sciencerun1.py
Outdated
| SigmaToR50 = 1.349 | ||
|
|
||
| class S1SingleScatter(sciencerun0.S1SingleScatter): | ||
| from scipy.stats import chi2 | ||
| version = 3 |
There was a problem hiding this comment.
Increment S1SingleScatter version?
pdeperio
reviewed
Nov 16, 2017
lax/lichens/sciencerun1.py
Outdated
| v_drift = 1.335 * (units.um) / units.ns | ||
| scg = 21.3 # s2_secondary_sc_gain in pax config | ||
| scw = 229.58 # s2_secondary_sc_width median | ||
| SigmaToR50 = 1.349 |
There was a problem hiding this comment.
This line necessary if you're not changing it?
There was a problem hiding this comment.
No, they are just overwriting the sr0 values here.
pdeperio
requested review from
andrewgrahambrown
and removed request for
adambrown1
pdeperio
approved these changes
Nov 16, 2017
pdeperio
suggested changes
Nov 23, 2017
There was a problem hiding this comment.
Request from @skazama to check against a wall leakage background control sample (provided by @AlexElykov?), and re-optimize accordingly if necessary.
|
The wall leakage background data provided by @jingqiangye have no specific feature in this cut space. As well as in S1/S2 pattern, S2 single scatter, S2 area fraction top. |
pdeperio
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the S2Width Cut, which is formulated according to Chi2 distribution.
Note
Fixes #81
Fixes #105