This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Get gains from CMT #172
Merged
Get gains from CMT #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the aftermath of XENONnT/straxen#457
JoranAngevaare
commented
Jun 23, 2021
Comment on lines
-403
to
+404
| self.to_pe = straxen.get_to_pe(self.run_id, self.config['gain_model'], | ||
| self.config['channel_map']['tpc'][1]+1) | ||
| self.to_pe = straxen.get_correction_from_cmt(self.run_id, | ||
| self.config['gain_model']) |
There was a problem hiding this comment.
Actually, this is the only change we really require for WFSim to run with straxen 0.19.0, the rest is just changed conventions for the testing.
zhut19
approved these changes
Jun 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the aftermath of XENONnT/straxen#457
Also, @zhut19 , I don't think pinning WFSim permanently is desirable: 3c925f1, I think we need to change that before making a new WFSim release. Would you agree?
straxen 0.19.0 does not exist yet but hopefully soon