This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Add n_pe to truth #246
Merged
Add n_pe to truth #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the n_photons field in the truth is the number of detected photons + double pe emission. This PR changes that to have n_photons be the number of detected photons and n_pe for the number of detected photo electrons (so photons+dpe)
|
@petergaemers , this is super useful! Would you think we could also add a small field for the number of photons actually passing the DAQ-thresholds, as in the number of "truely" registered hits? |
|
@petergaemers thanks for this! Can we also save the true sampled gain values? |
|
Hi guys, I'm sorry I completly missed these comments. First for Jorans we don't have a number of photons passing the threshold, we have a current which is a bunch of them. And for Evans point: maybe but it will not be straightforward at all. The main point is straxs fixed length arrays you need to set in advance |
|
@petergaemers thanks a lot! Do you think it would make sense to remove the |
|
Yes I do |
remove exclude dpe from truth option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the n_photons field in the truth is the number of detected photons + double pe emission.
This PR changes that to have n_photons be the number of detected photons and n_pe for the number of detected photo electrons (so photons+dpe)