Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Recompute lce on the run #269

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Recompute lce on the run #269

merged 3 commits into from
Nov 23, 2021

Conversation

zhut19
Copy link
Contributor

@zhut19 zhut19 commented Nov 22, 2021

What is the problem / what does the code in this PR do
As @terliuk found out, the turned-off PMT in LCE must match the ones in the to_pe model. This is especially true for S2s, LCE under 'OFF' PMTs is smaller, while the relative probabilities in the 'ON' PMTs are higher.

@zhut19 zhut19 requested a review from terliuk November 22, 2021 20:08
@zhut19 zhut19 marked this pull request as ready for review November 22, 2021 22:58
Copy link
Contributor

@terliuk terliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected, at least I do not see any features in the patterns that I used to have before.

@terliuk terliuk merged commit a2a5aeb into master Nov 23, 2021
@terliuk terliuk deleted the recompute_s2_map branch November 23, 2021 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants