This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
SPE spec bug fix, adding trigger truth #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @JoranAngevaare, I am adding the required fields including |
FaroutYLq
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR! This is really helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tianyu for this PR! Much appreciated. One piece of the code I don't fully follow, can you help me a bit?
Co-authored-by: Joran Angevaare <jorana@nikhef.nl>
I tested it and it really works great, thanks again Tianyu! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
trigger
truth to the truth values, includingn_photon_trigger
: number of photons that should pass the ADC trigger assuming no noise fluctuation; this also considers the possibility of one photon generating 2 PE and thus having a higher chance of passing ADC threshold.n_pe_trigger
: number of photons + dpe that should pass the ADC trigger assuming no noise fluctuationraw_area
: Sum of the gain per PE triggered