S2 optical prop #305
S2 optical prop #305
Conversation
|
Hi Melih, this looks good, but how do you propose we change the config to include 'confxy'? |
wfsim/core/s2.py
Outdated
| config=config, | ||
| resource=resource) | ||
| elif 'garfield' in config['s2_luminescence_model']: | ||
| confxy = True if 'confine distance' in config['s2_luminescence_model'] else False |
There was a problem hiding this comment.
@JYangQi00 Hi Jianyang currently, I added it here. So while comparing the two, I simulate once setting {'s2_luminescence_model':'garfield'} and once with {'s2_luminescence_model':'garfield confine distance'} so both confxy=True and confxy=False are callable
There was a problem hiding this comment.
If we are adding a parameter, does it make sense to make it float number that defines "range" of confinement? For example, negative value (i.e. -1) means that it is turned off, while positive value means that it will be confined to certain range (for example, (-value, +value)).
There was a problem hiding this comment.
here bee4444 it can now be set as
{'s2_luminescence_model':'garfield confxy=0.05'}
If there is no 'confxy=' string in s2_luminescence_model it uses the current default from master branch
There was a problem hiding this comment.
and here I uploaded a notebook, using this updates. I'm trying to compare the data vs WFSim with several configs
What is the problem / what does the code in this PR do
Samples optical propagation delays in the gas phase from a G4 simulated data.
The S2 pulse workflow is a bit changed; photon channels sampling is now independent from photon times. This was needed so that photon time delays can be added based on whether they are detected at top/bottom arrays.
!To add this effect it uses a local aux file for now, the file will be added to private_nt_aux repo!
WFSim needs you:
Pay attention: