-
Notifications
You must be signed in to change notification settings - Fork 9
Double PMT ap probability for photons emitting double PE. #340
Conversation
Hey @zhut19, thanks for the fix, now the population with the additional delay is gone! I still can't quite reproduce the afterpulse rates from the input file though, but the discrepancy has decreased significantly with the DPE addition, from -33% to -18%, shown in the second plot. Still not sure where this comes from, could be pile-up. But I don't think it's related to the DPE thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it does what this PR is supposed to do, so let's merge it and figure out why there is still remaining mismatch separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
What is the problem / what does the code in this PR do
The double photo-electron in PMTs also contributes to generating PMT afterpulse, in this pr, we store a boolean array noting photons emitting dpe, in the last step of generating S1s and S2s. While we double the PMT AP probability for those photons when generating PMT afterpulses.