Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

S1 pulse shape debug #381

Merged
merged 14 commits into from
Jun 9, 2022
Merged

S1 pulse shape debug #381

merged 14 commits into from
Jun 9, 2022

Conversation

zhut19
Copy link
Contributor

@zhut19 zhut19 commented Jun 7, 2022

What is the problem / what does the code in this PR do
The S1 photon timing from nestpy is not completely shuffled, the first n_exiton entries are just from primary excitons and the rest from recombination photons. See,
https://github.com/NESTCollaboration/nestpy/blob/fe3d5d7da5d9b33ac56fbea519e02ef55152bc1d/src/nestpy/NEST.cpp#L164-L179

Note: https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:j_angevaare:wfsim_photon_timing_bug

WFSim needs you:

  • Please add a test for this PR, as a bare minimum, make sure it's covered in coveralls!
  • Can you add a docsting to all your functions?

Pay attention:

  • Due to databases being needed for testing, making a PR from your own fork will typically NOT run the tests. If you then merge master might break

@coveralls
Copy link

coveralls commented Jun 7, 2022

Coverage Status

Coverage decreased (-0.03%) to 82.364% when pulling d1dcc9b on zhut19-patch-1 into c34ba24 on master.

@terliuk terliuk self-requested a review June 8, 2022 16:05
@ramirezdiego ramirezdiego marked this pull request as ready for review June 8, 2022 16:06
@ramirezdiego
Copy link
Collaborator

Linking this baby here: https://github.com/XENONnT/private_nt_aux_files/pull/202

wfsim/core/s1.py Outdated Show resolved Hide resolved
@terliuk terliuk merged commit b229b1d into master Jun 9, 2022
@terliuk terliuk deleted the zhut19-patch-1 branch June 9, 2022 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants