Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary warning given new ptype constraints #119

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Remove unnecessary warning given new ptype constraints #119

merged 2 commits into from
Dec 8, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Dec 8, 2023 •
edited
Loading

Just remove an unnecessary warning given all the attempts to change need_reinit parameters are all error-raised after #110.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7142516752

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 90.754%
Totals Coverage Status
Change from base Build 7081363175: -0.01%
Covered Lines: 1384
Relevant Lines: 1525
💛 - Coveralls

@dachengx dachengx marked this pull request as ready for review December 8, 2023 14:28
@hammannr hammannr merged commit fc9d8e4 into main Dec 8, 2023
7 checks passed
@hammannr hammannr deleted the rm_fittable_warning branch December 8, 2023 15:09
@dachengx dachengx added the enhancement New feature or request label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hammannr hammannr hammannr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @hammannr