Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check of already made toydata and output #128

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Improve check of already made toydata and output #128

merged 6 commits into from
Jan 17, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jan 7, 2024

Previously we only checked whether output_filename was made regardless of only_toydata, and did not checked toydata_filename.

In this PR, we check if:

  1. output_filename is made when not only_toydata
  2. toydata_filename is made when toydata_mode is generate_and_store

@dachengx dachengx marked this pull request as ready for review January 7, 2024 15:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7517567116

  • 15 of 17 (88.24%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.845%
Changes Missing Coverage Covered Lines Changed/Added Lines %
alea/submitter.py 15 17 88.24%
Totals Coverage Status
Change from base Build 7512701165: 0.01%
Covered Lines: 1409
Relevant Lines: 1551
💛 - Coveralls

@dachengx dachengx requested review from hammannr and kdund January 7, 2024 15:50
hammannr
hammannr approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@hammannr hammannr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this! 😊

@dachengx dachengx merged commit 6e9116a into main Jan 17, 2024
7 checks passed
@dachengx dachengx deleted the smarter_already_done branch January 17, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hammannr hammannr hammannr approved these changes

@kdund kdund Awaiting requested review from kdund

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @hammannr