-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug for interpolator deduction of NeymanConstructor
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9417365502Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9417367161Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9417367161Details
💛 - Coveralls |
dachengx
commented
Jun 7, 2024
@@ -472,7 +478,6 @@ def get_confidence_interval_thresholds( | |||
) | |||
|
|||
# get the poi_values and threshold_values for interp1d | |||
interpolator = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why we have this line. So remove it.
hammannr
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @dachengx !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deducing the interpolator, we collect the threshold for each combination of nominal_values and generate_value. Then make an interpolator whose x are
generate_value
and y are the thresholds. This line was meant to assign a 1D array to the map:alea/alea/submitters/local.py
Line 399 in cce3ea0
But when the dimension of the
generate_values
is high, which meansindices
is a list,values[indices]
is not a 1D array butvalues[tuple(indices)]
is actually the function we want.Demo: