Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Keep only one Directory.SHARED_SCRATCH" #223

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Oct 2, 2024

Reverts #222

So my statement in the previous PR is incorrect: #222 (comment).

Otherwise, we will see errors when job submission like:

Pegasus.client._client.PegasusClientError: Pegasus command: ['/usr/bin/pegasus-plan', '-Dpegasus.metrics.app=XENON', '-Dpegasus.data.configuration=nonsharedfs', '-Ddagman.retry=0', '-Ddagman.maxidle=100000', '-Ddagman.maxjobs=100000', '-Dpegasus.transfer.threads=4', '-Dpegasus.monitord.encoding=json', '-Dpegasus.catalog.workflow.amqp.url=amqp://friend:donatedata@msgs.pegasus.isi.edu:5672/prod/workflows', '--cluster', 'horizontal', '--sites', 'condorpool', '--output-sites', 'local', '--staging-site', 'condorpool=staging-davs', '--dir', '/scratch/xudc/workflows/wimp_ac_optimization-discovery_power-202410021020', '--relative-dir', 'runs', '--cleanup', 'none', '--submit', '/scratch/xudc/workflows/wimp_ac_optimization-discovery_power-202410021020/generated/workflow.yml', '--json'] FAILED

@dachengx dachengx requested a review from FaroutYLq October 2, 2024 17:05
@dachengx dachengx marked this pull request as ready for review October 2, 2024 17:06
@coveralls
Copy link

coveralls commented Oct 2, 2024

Pull Request Test Coverage Report for Build 11148290885

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 89.51%

Totals Coverage Status
Change from base Build 11132341269: -0.05%
Covered Lines: 1681
Relevant Lines: 1878

💛 - Coveralls

@dachengx dachengx merged commit dcd4de0 into main Oct 2, 2024
6 checks passed
@dachengx dachengx deleted the revert-222-single_shared_scratch branch October 2, 2024 17:10
Copy link
Contributor

@FaroutYLq FaroutYLq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't understand why failure happens in #222. Does it mean that a scratch is required to be formally there, even though not necessarily used?

@dachengx
Copy link
Collaborator Author

dachengx commented Oct 2, 2024

I guess that is because we submit the job of "separation". I checked the local scratch folder of the old workflow that was successfully finished, and found there are tarballs of outputs in it.

So this means the local job needs a local scratch.

@dachengx
Copy link
Collaborator Author

dachengx commented Oct 2, 2024

It also needs a local output folder otherwise error shows, maybe because pegasus anticipates that we have to output something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants