-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First runner manipulating statistical model #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pep8
alea/runner.py|75 col 1| D102 Missing docstring in public method
alea/runner.py|75 col 5| WPS615 Found unpythonic getter or setter
alea/runner.py|90 col 70| C812 missing trailing comma
alea/runner.py|100 col 1| D102 Missing docstring in public method
alea/runner.py|103 col 9| WPS221 Found line with high Jones Complexity: 15 > 14
alea/runner.py|105 col 22| WPS510 Found in
used with a non-set container
alea/runner.py|113 col 48| WPS441 Found control variable used after block: ea
alea/runner.py|124 col 1| D102 Missing docstring in public method
alea/runner.py|128 col 1| D102 Missing docstring in public method
alea/runner.py|158 col 101| E501 line too long (105 > 100 characters)
alea/runner.py|175 col 1| D102 Missing docstring in public method
alea/statistical_model.py|60 col 9| E121 continuation line under-indented for hanging indent
alea/statistical_model.py|60 col 9| E125 continuation line with same indent as next logical line
alea/examples/gaussian_model.py|14 col 5| E125 continuation line with same indent as next logical line
alea/examples/gaussian_model.py|14 col 9| E121 continuation line under-indented for hanging indent
Quite a bit of linting-- are you using an automatic tool for it, @dachengx ? |
Trying to resolve #3 and #16
What does the code in this PR do / what does it improve?
The runner manipulates the statistical model.
It:
Can you briefly describe how it works?
The changes except in
runner.py
is only some format changes, not crucial.likelihood_config
should be contained instatistical_model_args
if needed.fit_guesses
is defined inParameters
.Can you give a minimal working example (or illustrate with a figure)?
toydata-generating runner:
toydata-reading runner:
What are the potential drawbacks of the codes?
Things should be implemented later:
Please include the following if applicable:
Notes on testing
All italic comments can be removed from this template.