Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify and clean code style and docstring #68
Unify and clean code style and docstring #68
Changes from 28 commits
51eceb8
ada2cdc
274be84
8e69318
fe72dc9
3c6f281
ee0da2f
de83227
2e4c06c
0237c1f
617fa8b
e9515c4
6772eca
d4e0f20
7de6852
908b49d
7bc1389
6c303f0
81069f6
02273ea
ca54caa
c4fdf7b
714fb7e
f1b33a5
d834e81
0311397
90b86c2
0588fe9
7f5657b
10b8d97
4529a7f
01bb5ed
702353b
42e4d7f
2682d9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we warn that no nominal values are set here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you properly call the ll via
.ll
instead of._ll
it should parse the defaults or notThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure but I think it's possible to run into a useless error if you don't define the defaults and then mu and sigma stay None and are parsed to stats.norm.. Maybe it would make sense to catch this case and provide a more useful error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do catch it-- but it is nice to point out this stumbling block in the documentation, in particular since this is a tutorial model, that fails if you use it naively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated at https://alea--68.org.readthedocs.build/en/68/reference/alea.examples.html#module-alea.examples.gaussian_model